feat: Add horizontal scrolling support to GridElement (#8046) #8047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements scrollToColumn method to enable horizontal scrolling in Grid, particularly useful when columnRendering is set to lazy. This addresses the issue where cells return null when columns are out of view. New features: - scrollToColumn(GridColumnElement) - scrolls to specific column - scrollToColumn(int columnIndex) - scrolls to column by index - isColumnInView(GridColumnElement) - checks if column is visible - Automatic column scrolling in getCell() method This enhancement allows reliable testing of grids with many columns and lazy column rendering, fixing the issue where it was impossible to distinguish between genuinely null cells and cells not rendered due to being out of view. Fixes #8046 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixed compilation error by using ColumnRendering.LAZY instead of the non-existent Grid.ColumnRenderingMode.LAZY
The scrollToColumn method was using a non-existent grid.$.table.scrollToColumn(index) API. Fixed to properly manipulate table.scrollLeft to scroll columns into view based on their position relative to the table viewport. This fix ensures horizontal scrolling works correctly with lazy column rendering, allowing cells to be accessed reliably even when columns are initially out of view. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
ugur-vaadin
requested changes
Oct 21, 2025
| column.__generatedTbId = grid.__generatedTbId++; | ||
| } | ||
| }); | ||
| return grid._getColumns().length; |
There was a problem hiding this comment.
Suggested change
| return grid._getColumns().length; |
This new line seems to serve no purpose.
| * Gets the grid cell for the given row and column. | ||
| * <p> | ||
| * Automatically scrolls the given row into view | ||
| * Automatically scrolls the given row and column into view |
There was a problem hiding this comment.
This JavaDoc update should also be applied to the JavaDoc of the other overload.
| * the column to check | ||
| * @return {@code true} if the column is visible, {@code false} otherwise | ||
| */ | ||
| public boolean isColumnInView(GridColumnElement column) { |
There was a problem hiding this comment.
I think we can keep this private for now, similar to how it is with isRowInView.
| @@ -0,0 +1,72 @@ | |||
| /* | |||
There was a problem hiding this comment.
The tests seem to be testing whether the GridElement API is working rather than the Grid itself. I think we can remove the page and the test class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements scrollToColumn method to enable horizontal scrolling in Grid, particularly useful when columnRendering is set to lazy. This addresses the issue where cells return null when columns are out of view.
New features:
This enhancement allows reliable testing of grids with many columns and lazy column rendering, fixing the issue where it was impossible to distinguish between genuinely null cells and cells not rendered due to being out of view.
Fixes #8046